Skip to content

Upgrade to python track2 sdk for purview#12634

Merged
msyyc merged 6 commits intoAzure:masterfrom
00Kai0:purview-upgrade-track2
Jan 29, 2021
Merged

Upgrade to python track2 sdk for purview#12634
msyyc merged 6 commits intoAzure:masterfrom
00Kai0:purview-upgrade-track2

Conversation

@00Kai0
Copy link
Copy Markdown
Contributor

@00Kai0 00Kai0 commented Jan 26, 2021 •
edited
Loading

@00Kai0 00Kai0 requested a review from msyyc January 26, 2021 03:59
@00Kai0 00Kai0 requested a review from lirenhe as a code owner January 26, 2021 03:59
@openapi-workflow-bot
Copy link
Copy Markdown

openapi-workflow-bot bot commented Jan 26, 2021

Hi, @00Kai0 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented Jan 26, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented Jan 26, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08688f3. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-purview [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog]   - Initial Release
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08688f3. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/purview/mgmt/2020-12-01-preview/purview [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 26, 2021
    Draft
    @00Kai0 00Kai0 requested a review from changlong-liu January 27, 2021 09:31
    msyyc
    msyyc reviewed Jan 29, 2021
    View reviewed changes
    specification/purview/resource-manager/readme.md Outdated
    @@ -77,23 +77,19 @@ Use `--python-mode=update` if you already have a setup.py and just want to updat

    ``` yaml $(python)
    Copy link
    Copy Markdown
    Member

    @msyyc msyyc Jan 29, 2021

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    configure python in 'readme.python.md'

    msyyc
    msyyc reviewed Jan 29, 2021
    View reviewed changes
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 29, 2021
    Closed
    @00Kai0 00Kai0 requested a review from jsntcy as a code owner January 29, 2021 07:50
    @msyyc msyyc merged commit 08688f3 into Azure:master Jan 29, 2021
    This was referenced Jan 29, 2021
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @msyyc msyyc msyyc approved these changes

    @lirenhe lirenhe Awaiting requested review from lirenhe

    @changlong-liu changlong-liu Awaiting requested review from changlong-liu

    @jsntcy jsntcy Awaiting requested review from jsntcy

    Assignees

    @qianwens qianwens

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @00Kai0 @msyyc @qianwens